-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(language-core): remove experimentalAdditionalLanguageModules
and deprecated APIs
#3907
Conversation
…s` and deprecated apis
"experimentalAdditionalLanguageModules": { | ||
"deprecated": true, | ||
"type": "array", | ||
"markdownDescription": "https://github.com/vuejs/language-tools/pull/2267" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's removed then the property should be removed instead of marked as deprecated IMO.
If the idea is that the link provides some info about removal then it's a wrong link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've assumed that the schema uses "additionalProperties": false
so that the removal would raise and error. But I see that it's not the case. I think that adding it would make sense so that this could be removed and also people would see issues if they mistype some option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't get "additionalProperties": false
to work, please feel free to open a PR if you get it to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
additionalProperties
might not work if there are multiple schemas extending the same object but then my question is: do deprecated properties really need to be separated into its own file? If they wouldn't then it would be easy to use additionalProperties: false
.
BTW. deprecated
is not a meant to be used for functionality that is removed but only for that that is still supported but discouraged. With additionalProperties:false
we could express both removed and deprecated properties.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this works and implement by 777b0a1, thanks!
Changes
createLanguages
APIcreateVueLanguage
API rename tocreateVueLanguagePlugin
experimentalAdditionalLanguageModules
, alternatives will be provided (probably after v2 is released)