-
-
Notifications
You must be signed in to change notification settings - Fork 432
fix(vue-tsc): update required volar version #4498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CI runs with --frozen-lockfile which contains dependency versions that don't match with what will be installed in the end in userland because the lockfile is not shipped. This results in tests not running on the same code as will be installed for the user
Why don you update this to 2.3.3 |
I've created this PR before 2.3.3 was released |
Not sure if @johnsoncodehk wants to pin to an exact volar version? I imagine you'd like to be flexible in updating volar without needing to re-publish vue-tsc. The problem is just the possibility of having upstream regressions when volar is updated. Feel free to close this one. |
@davidmatter I think we can add a CI test to test without |
Well, if I think about it: Even if we run CI without |
I just updated the PR to update the required version to
This is what https://github.com/volarjs/ecosystem-ci for, it got a little damaged recently and I'm going to get it working again. |
CI runs with --frozen-lockfile which contains dependency versions that don't match with what will be installed in the end in userland because the lockfile is not shipped.
This results in tests not running on the same code as will be installed for the user, causing e.g. #4497