Skip to content

fix(vue-tsc): update required volar version #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

davidmatter
Copy link
Collaborator

@davidmatter davidmatter commented Jun 24, 2024

CI runs with --frozen-lockfile which contains dependency versions that don't match with what will be installed in the end in userland because the lockfile is not shipped.

This results in tests not running on the same code as will be installed for the user, causing e.g. #4497

davidmatter and others added 2 commits June 24, 2024 08:22
CI runs with --frozen-lockfile which contains dependency versions that don't match with what will be installed in the end in userland because the lockfile is not shipped.

This results in tests not running on the same code as will be installed for the user
@davidmatter davidmatter linked an issue Jun 24, 2024 that may be closed by this pull request
@Ciscodefran
Copy link

Why don you update this to 2.3.3
https://github.com/volarjs/volar.js/releases/tag/v2.3.3

@davidmatter
Copy link
Collaborator Author

I've created this PR before 2.3.3 was released

@davidmatter
Copy link
Collaborator Author

Not sure if @johnsoncodehk wants to pin to an exact volar version? I imagine you'd like to be flexible in updating volar without needing to re-publish vue-tsc. The problem is just the possibility of having upstream regressions when volar is updated. Feel free to close this one.

@johnsoncodehk
Copy link
Member

@davidmatter I think we can add a CI test to test without --frozen-lockfile flag. Would you want to update this PR for it?

@davidmatter
Copy link
Collaborator Author

davidmatter commented Jun 24, 2024

Well, if I think about it: Even if we run CI without --frozen-lockfile, updating volar can still break the language tools when it's not pinned to a specific version as it's a direct dependency of vue-tsc that users will automatically fetch when they update their dependencies. Removing --frozen-lockfile would only help when vue-tsc is re-published :)
If semver is used, this should not be a problem in general - we just need to be careful not to introduce breaking changes when not pinned.

@johnsoncodehk
Copy link
Member

I just updated the PR to update the required version to ~2.3.4 to avoid installing the regression 2.3.2.

If semver is used, this should not be a problem in general - we just need to be careful not to introduce breaking changes when not pinned.

This is what https://github.com/volarjs/ecosystem-ci for, it got a little damaged recently and I'm going to get it working again.

@johnsoncodehk johnsoncodehk changed the title fix(vue-tsc): pin volar version fix(vue-tsc): update required volar version Jun 24, 2024
@johnsoncodehk johnsoncodehk merged commit 4a295b6 into master Jun 24, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the davidmatter-patch-1 branch June 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: VirtualCode id must be lowercase: scriptSetupFormat
3 participants