New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better sfc-level tag name completion #4506

Merged

johnsoncodehk merged 1 commit into vuejs:master from KermanX:feat/sfc-level-completion

Jun 26, 2024

Collaborator

KermanX commented Jun 26, 2024 •

edited

Loading

Typing lang="ts" every time when start writing a new SFC is very annoying. This PR adds completion for that.

Before
After

Improvements

Removed !DOCTYPE and Custom Blocks
Add script lang="ts" and script setup lang="ts"

Notes

The description of script lang="ts" is the same as script, and the description of script setup lang="ts" is the same as script setup. I am not sure how to update this.
Exact matching is used in this PR. I don't know if a looser matching method should be used.
Should the order of the completion items be changed?


          feat: better sfc-level tag name completion

7b6978e

Member

johnsoncodehk commented Jun 26, 2024

LGTM, thanks!

johnsoncodehk merged commit 5325079 into vuejs:master

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet