Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(language-core): auto infer type for $refs & useTemplateRef #4644

Merged
merged 17 commits into from
Aug 25, 2024
Merged

feat(language-core): auto infer type for $refs & useTemplateRef #4644

merged 17 commits into from
Aug 25, 2024

Conversation

zhiyuanzmj
Copy link
Collaborator

@zhiyuanzmj zhiyuanzmj commented Aug 5, 2024 •
edited
Loading

Auto infer type for useTemplateRef and $refs.

  1. The useTemplateRef is very useful for generic component.
  2. The $refs can be nested.
image

@zhiyuanzmj zhiyuanzmj marked this pull request as draft August 5, 2024 02:58
@zhiyuanzmj zhiyuanzmj marked this pull request as ready for review August 9, 2024 07:09
@zhiyuanzmj zhiyuanzmj marked this pull request as draft August 9, 2024 09:31
@zhiyuanzmj zhiyuanzmj marked this pull request as ready for review August 9, 2024 10:54
@zhiyuanzmj zhiyuanzmj mentioned this pull request Aug 12, 2024
Open
5 tasks
@zhiyuanzmj zhiyuanzmj changed the title feat(language-core): introduce template-ref feat(language-core): Add type for $refs & useTemplateRef Aug 15, 2024
@zhiyuanzmj zhiyuanzmj changed the title feat(language-core): Add type for $refs & useTemplateRef feat(language-core): auto infer type for $refs & useTemplateRef Aug 15, 2024
@zhiyuanzmj zhiyuanzmj mentioned this pull request Aug 20, 2024
Merged
5 tasks
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Aug 25, 2024 •
edited
Loading

commit: ada16b8

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4644

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4644

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4644

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4644

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4644

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4644

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4644

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4644

Open in Stackblitz

@johnsoncodehk
Copy link
Member

Awesome, thanks!

@johnsoncodehk johnsoncodehk merged commit 4dd5ee9 into master Aug 25, 2024
9 checks passed
@johnsoncodehk johnsoncodehk deleted the feat/template-ref branch August 25, 2024 21:40
@johnsoncodehk johnsoncodehk restored the feat/template-ref branch August 25, 2024 21:44
@johnsoncodehk johnsoncodehk deleted the feat/template-ref branch August 25, 2024 21:44
@KazariEX KazariEX mentioned this pull request Aug 30, 2024
Closed
sxzz added a commit to vue-macros/vue-macros that referenced this pull request Sep 5, 2024
@sxzz
refactor(volar)!: drop templateRef plugin
c152956 
Since the feature is supported via vuejs/language-tools#4644
sxzz added a commit to vue-macros/vue-macros that referenced this pull request Sep 5, 2024
@sxzz
refactor(volar)!: drop templateRef plugin
0290218 
Since the feature is supported via vuejs/language-tools#4644
@mcsaur mcsaur mentioned this pull request Sep 20, 2024
Open
@makedopamine makedopamine mentioned this pull request Nov 1, 2024
Merged
@WontonSam WontonSam mentioned this pull request Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhiyuanzmj @johnsoncodehk