fix: should try casting dynamic slot name into constant #4669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4668.
Introduced a new helper:
which is used to infer the type of an arbitrary expression like
as const
, but not throwing errors when this can't be done. For example,("1" + "2") as const
will be an error, but__VLS_tryAsConstant("1" + "2")
will just be of typestring
.btw, I think
__VLS_tryAsConstant
can be used in other places to provide more precise type info - but it may cause performance issues.