Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): generate ref as identifier instead of interpolation #4688

Merged
merged 3 commits into from
Aug 25, 2024

Conversation

KazariEX
Copy link
Collaborator

@KazariEX KazariEX commented Aug 13, 2024

When using some characters like - as identifiers for ref, the incorrect virtual code will be generated.

Copy link

pkg-pr-new bot commented Aug 25, 2024

commit: df1ac34

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4688

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4688

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4688

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4688

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4688

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4688

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4688

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4688

Open in Stackblitz

@johnsoncodehk
Copy link
Member

LGTM, thanks!

@johnsoncodehk johnsoncodehk merged commit ebc8710 into vuejs:master Aug 25, 2024
5 checks passed
@KazariEX KazariEX deleted the fix/generate-ref branch August 31, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants