-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(language-service): add style scoped and module completion #4705
feat(language-service): add style scoped and module completion #4705
Conversation
I think there is no need to extract languages to the top level, as it might be obtained from provider in the future. #4645 What about |
Hi @KazariEX, I apologize for not seeing your PR earlier. |
Just update directly, I think they belong to the same feature. |
@KazariEX I've updated my PR to |
Sorry I didn't mean replacement but both |
No problem. I will update now. |
@KazariEX I've updated my PR with |
commit: vue-component-meta
vue-component-type-helpers
@vue/language-core
@vue/language-plugin-pug
@vue/language-server
@vue/language-service
vue-tsc
@vue/typescript-plugin
|
LGTM, thanks! |
Updated
style module
completion with a new screenshotchange tostyle module
completion instead ofstyle scoped
with a new screenshotOverview
I've added the
scoped
andmodule
attributes to style completion items.Now, when we type
style
in completion,scoped
andmodule
are available as options.Screenshots
Screen.Recording.2567-08-19.at.01.14.32.mov
This is my first PR. If you have any feedback or suggestions, please do not hesitate to let me know.