Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): use tsup for tree-shaking #4990

Closed
wants to merge 9 commits into from
Closed

chore(vscode): use tsup for tree-shaking #4990

wants to merge 9 commits into from

Conversation

zhiyuanzmj
Copy link
Collaborator

No description provided.

Copy link

pkg-pr-new bot commented Nov 6, 2024

Open in Stackblitz

vue-component-meta

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4990

vue-component-type-helpers

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4990

@vue/language-plugin-pug

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4990

@vue/language-core

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4990

@vue/language-server

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4990

@vue/language-service

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4990

vue-tsc

pnpm add https://pkg.pr.new/vuejs/language-tools/vue-tsc@4990

@vue/typescript-plugin

pnpm add https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4990

commit: f3b43c3

@johnsoncodehk johnsoncodehk marked this pull request as draft November 6, 2024 19:40
@johnsoncodehk
Copy link
Member

It seems that dist/client.js does not bundle the modules it depends on (reactive-vscode, @volar/vscode...)

@zhiyuanzmj
Copy link
Collaborator Author

Oh, I was wrong. The PR can't tree-shaking. It's only use require instead of build-in bundle. But the VSCode plugin don't have node_modules. So I closed the PR.

@zhiyuanzmj zhiyuanzmj closed this Nov 7, 2024
@johnsoncodehk
Copy link
Member

No problem, thank you for exploring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants