Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-core): move generateSfcBlockSection to the end to fix missing comma errors #5184

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

zhiyuanzmj
Copy link
Member

If defineComponent's options don't end with a comma, it will cause a TS 1005 error.

image

Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@5184

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@5184

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@5184

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@5184

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@5184

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@5184

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@5184

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@5184

commit: 2ac6249

@johnsoncodehk johnsoncodehk merged commit b658051 into master Feb 16, 2025
9 checks passed
@johnsoncodehk johnsoncodehk deleted the fix-ts-1005 branch February 16, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants