Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(zh): Update getting-started.md #1999

Closed
wants to merge 1 commit into from

Conversation

jeremygoccc
Copy link
Contributor

modify the vue version explanation

modify the vue version explanation
@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for pinia-official ready!

Name Link
🔨 Latest commit 72b2d10
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/63ea07e0d67cd30008095638
😎 Deploy Preview https://deploy-preview-1999--pinia-official.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@posva posva changed the base branch from v2 to docs/vitepress-1 February 13, 2023 10:00
@posva posva added the 📚 docs Related to documentation changes label Feb 13, 2023
@YFengFly
Copy link
Contributor

Sorry to bother you, I provided some same PR earlier:
#1979
#1975

Due to the premise of PR, there are a lot of commit conflicts, so I closed this PR, the new one is:
#2000

In my opinion,

如果你的应用使用的 Vue 版本低于 2.7

maybe better than:

如果你的应用使用的是 Vue 2.7 以下版本

This is discussed in : #1975
@awxiaoxian2020

However,I don't think this is the best way to translate, it's still feel a little strange.

Which one is better ? or... any suggestion?

posva pushed a commit that referenced this pull request Feb 13, 2023
@posva
Copy link
Member

posva commented Feb 13, 2023

Thanks! I merged #2000 because the original PR was older

@posva posva closed this Feb 13, 2023
posva pushed a commit that referenced this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Related to documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants