-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(devtools): expose selected store as global variable #2692
feat(devtools): expose selected store as global variable #2692
Conversation
✅ Deploy Preview for pinia-official canceled.
|
❌ Deploy Preview for pinia-playground failed.
|
This is nice! Maybe
|
Sorry, I didn't understand, did you mean
|
yes |
Implemented in 36a56a8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I moved it to globalThis
to support more runtimes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v2 #2692 +/- ##
==========================================
+ Coverage 94.51% 95.46% +0.94%
==========================================
Files 12 11 -1
Lines 3248 2912 -336
Branches 219 189 -30
==========================================
- Hits 3070 2780 -290
+ Misses 174 131 -43
+ Partials 4 1 -3 ☔ View full report in Codecov by Sentry. |
Is this compatible with the new version of the devtools? It seems to not be working. (I didn't try it on the legacy devtools of the video.) |
Refs: #732
Clicking on a store in pinia devtools should make it available as a global variable
Screen.Recording.2024-06-13.at.23.52.16.mov