fix(types): Don't double UnwrapRef in setup stores #2771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2770
Without this change for setup stores
UnwrapRef
is applied to state type twice.First time after defineStore infers the
SS
type parameter and passes it to_ExtractStateFromSetupStore
:pinia/packages/pinia/src/types.ts
Line 586 in 3c8782e
Then the result of
_ExtractStateFromSetupStore<SS>
is passed toStoreDefinition
interface, which passes it toStore
type, which doespinia/packages/pinia/src/types.ts
Line 470 in 3c8782e
First unwrap call reduces state type
Second unwrap call reduces it further producing type that doesn't match the runtime value