-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: add chobitsu
(Chrome Devtools) for preview
#201
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to load the entire devtools frontend which is pretty heavy. I think at the very least it should be added as an opt-in feature that doesn't affect the bundle size of the current base use case (embedding).
src/output/devtools.html
Outdated
<meta name="referrer" content="no-referrer" /> | ||
<script | ||
type="module" | ||
src="https://cdn.jsdelivr.net/npm/chii/public/front_end/entrypoints/chii_app/chii_app.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would make this feature require a network connection.
Currently the repl doesn't use CDN unless the user is selecting a published version of Vue. If a feature requires internet connection then it should be made opt-in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a chii
option in Repl
to replace origin
when deploying to load chii
resources. A small plugin for vite has also been added to load the value for chii
import VitePluginChii from '@vue/repl/plugin-chii'
import chii from 'virtual:chii'
function App() {
return <Repl chii={chii} ... />
}
Should I add a separate |
Resolves: #197