-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use monaco #34
feat: use monaco #34
Conversation
This makes the embed a lot larger - ideally, we want it to be swappable: import { Repl, MonacoEditor, CodemirrorEditor } from '@vue/repl' <Repl :editor="MonacoEditor" /> An editor implementation is required so that we can treeshake the one that is not used - this will be a breaking change and we can release 2.0 for that. |
Can we add a shortcut to format code? (using Prettier?) |
Alternatively, to make it easier:: import { MonacoRepl, CodemirrorRepl } from '@vue/repl' |
Adapt volar into monaco. /cc: @johnsoncodehk I'm mot familiar enough with volar, hope to get some comments. @Justineo Might be interested in this too. |
Cool! Thanks @johnsoncodehk ! |
I'd like to extrace the monaco impl to avoid default monaco editor implementation soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
db27e23
to
abbc04d
Compare
No description provided.