Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use monaco #34

Merged
merged 77 commits into from
Jun 19, 2023
Merged

feat: use monaco #34

merged 77 commits into from
Jun 19, 2023

Conversation

Kingwl
Copy link
Member

@Kingwl Kingwl commented May 16, 2022

No description provided.

@Kingwl Kingwl marked this pull request as draft May 16, 2022 11:25
@yyx990803
Copy link
Member

This makes the embed a lot larger - ideally, we want it to be swappable:

import { Repl, MonacoEditor, CodemirrorEditor } from '@vue/repl'
<Repl :editor="MonacoEditor" />

An editor implementation is required so that we can treeshake the one that is not used - this will be a breaking change and we can release 2.0 for that.

@sxzz
Copy link
Member

sxzz commented May 17, 2022

Can we add a shortcut to format code? (using Prettier?)

@yyx990803
Copy link
Member

Alternatively, to make it easier::

import { MonacoRepl, CodemirrorRepl } from '@vue/repl'

@Kingwl
Copy link
Member Author

Kingwl commented May 18, 2022

Adapt volar into monaco.

/cc: @johnsoncodehk I'm mot familiar enough with volar, hope to get some comments.

@Justineo Might be interested in this too.

Kapture 2022-05-18 at 17 15 48

@yyx990803 yyx990803 mentioned this pull request May 25, 2022
@Kingwl
Copy link
Member Author

Kingwl commented Jun 9, 2022

Cool! Thanks @johnsoncodehk !

@Kingwl
Copy link
Member Author

Kingwl commented Jun 9, 2022

I'd like to extrace the monaco impl to avoid default monaco editor implementation soon.

@johnsoncodehk johnsoncodehk marked this pull request as draft May 21, 2023 10:16
@johnsoncodehk johnsoncodehk marked this pull request as ready for review May 22, 2023 01:57
Copy link
Member Author

@Kingwl Kingwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yyx990803 yyx990803 merged commit bdcf241 into vuejs:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants