Skip to content

Attr coercion behavior change #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 2, 2020
Merged

Attr coercion behavior change #126

merged 5 commits into from
Apr 2, 2020

Conversation

Justineo
Copy link
Member

@Justineo Justineo commented Feb 1, 2020

This RFC describes the changes we intend to make about attribute coercion behavior.

Rendered

@Justineo Justineo added breaking change This RFC contains breaking changes or deprecations of old API. core 3.x This RFC only targets 3.0 and above labels Feb 1, 2020
@jacekkarczmarczyk
Copy link

How attr="attr" should behave? draggable="attr" or draggable="" or draggable="true"?

See:
https://github.com/vuetifyjs/vuetify/blob/3a510e8af57d76da660c6b4a407f7940fefae5cb/packages/vuetify/src/mixins/detachable/index.ts#L126

@Justineo
Copy link
Member Author

Justineo commented Feb 1, 2020

How attr="attr" should behave? draggable="attr" or draggable="" or draggable="true"?

This RFC only affects attributes defined by v-bind. Otherwise the attribute won't be coerced.

@yyx990803 yyx990803 added the final comments This RFC is in final comments period label Mar 25, 2020
@yyx990803
Copy link
Member

This RFC is now in final comments stage. An RFC in final comments stage means that:

The core team has reviewed the feedback and reached consensus about the general direction of the RFC and believe that this RFC is a worthwhile addition to the framework.
Final comments stage does not mean the RFC's design details are final - we may still tweak the details as we implement it and discover new technical insights or constraints. It may even be further adjusted based on user feedback after it lands in an alpha/beta release.
If no major objections with solid supporting arguments have been presented after a week, the RFC will be merged and become an active RFC.

@yyx990803 yyx990803 merged commit e772b64 into master Apr 2, 2020
@Justineo Justineo deleted the attr-coercion branch April 2, 2020 02:19
@edikdeisling
Copy link

edikdeisling commented Apr 24, 2020

@Justineo link is broken, could you please update it? I suppose this is valid link.
https://github.com/vuejs/rfcs/blob/master/active-rfcs/0024-attribute-coercion-behavior.md

@yyx990803 yyx990803 removed the final comments This RFC is in final comments period label Jul 1, 2020
@bencodezen bencodezen mentioned this pull request Jul 6, 2020
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x This RFC only targets 3.0 and above breaking change This RFC contains breaking changes or deprecations of old API. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants