Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Vue Router section #7

Closed
afontcu opened this issue Apr 8, 2020 · 9 comments
Closed

feat: add Vue Router section #7

afontcu opened this issue Apr 8, 2020 · 9 comments
Assignees

Comments

@afontcu
Copy link
Member

afontcu commented Apr 8, 2020

  • showcase how to mock Vue Router.
  • showcase how to use router-link-stub (source).
  • avoid common pitfalls when trying to assert against a URL.
@lmiller1990
Copy link
Member

lmiller1990 commented Jun 28, 2020

I would like to work on this one. I learned a lot about the new Vue Router and the pitfalls (see here for example).

I think this article can go something like this:

  • example w/o mock
  • discuss async routing, flush promises, nextTick
  • demonstrate mocking Vue Router
  • discuss pros/cons of each approach

@lmiller1990 lmiller1990 self-assigned this Jun 28, 2020
@afontcu
Copy link
Member Author

afontcu commented Jun 28, 2020

Sounds great!

@posva
Copy link
Member

posva commented Jun 28, 2020

Ping me for a review when you have something. I already had some ideas about things to add so I could help on this one

@lmiller1990
Copy link
Member

@posva will do, would be great to get your review. Anything you think is especially important to mention?

@posva
Copy link
Member

posva commented Jun 30, 2020

Nothing specific but it would be useful being able to change the current location easily

@lmiller1990
Copy link
Member

I will hold off on this one until we discuss router testing more here: vuejs/test-utils#152

@afontcu
Copy link
Member Author

afontcu commented Jan 16, 2021

Closed in #43

@afontcu afontcu closed this as completed Jan 16, 2021
@lmiller1990
Copy link
Member

We might want to consider adding something about Vue Mock Router: https://github.com/posva/vue-router-mock

@afontcu
Copy link
Member Author

afontcu commented Jan 18, 2021

Right! Let me create a new issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants