fix: expose with render function #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vuejs#1065 When we are testing a component with a render function returned by the setup, then its proxy will be empty. The behavior difference can be seen in vue-next [here](https://github.com/vuejs/vue-next/blob/d19cfc0503dddbded5e599bef0965aba3d25ca28/packages/runtime-core/src/component.ts#L674). In that case, `wrapper.vm` will be empty if we return `vm.$.proxy`. To handle it, we return `vm` directly for such components, allowing at least what is exposed publicly to be available on `wrapper.vm`.
cexbrayat
force-pushed
the
fix/1065-expose-render-function
branch
from
80e9390
to
48da341
Compare
lmiller1990
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1065
When we are testing a component with a render function returned by the setup,
then its proxy will be empty.
The behavior difference can be seen in vue-next here.
In that case,
wrapper.vmwill be empty if we returnvm.$.proxy.To handle it, we return
vmdirectly for such components,allowing at least what is exposed publicly to be available on
wrapper.vm.