fix: re-add peer dependencies but with wider range (#2507) #2511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- no peer dependencies causes @vue/test-utils to import stuff from the wrong Vue version in monorepos with multiple Vue versions - too specific peer dependencies causes dependant projects not to be updated or find a valid Vue version so the range has been widened closes 2507
✅ Deploy Preview for vue-test-utils-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cexbrayat
approved these changes
Sep 19, 2024
gitworkflows
pushed a commit
to khulnasoft-lab/khulnasoft-ui
that referenced
this pull request
Jun 3, 2025
This new version includes vuejs/test-utils@74c9af4, which means we need to differentiate between Vue warnings and Vue errors. We also add `@vue/server-renderer` as a dev dependency. It *should* be marked as an optional peer dependency, but there hasn't been a release of VTU@2 with the fix included yet: vuejs/test-utils#2511. Furthermore, even though it's "optional", if we don't install it, Jest complains about not being able to find it, since it ends up being `require`d in the top level scope of the VTU@2 module. Finally, the new version also includes a fix that means we can remove our warning ignore list: vuejs/test-utils#2413.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes 2507