fix: spy on wrapper.vm with Jest #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a dirty fix that I'm not super proud of, and which needs a fix in vue-next. |
|
hm, CI failing? |
I think we still need vuejs/core#3105 to be merged and released? |
|
Yes exactly, we need my PR on vue-next to land (if that's the right move, we'll see!). |
|
Right, true. |
This allows Jest to spy on the proxied vm Fixes #309
cexbrayat
force-pushed
the
repro/spy-on-vm
branch
from
c7e9336
to
d055022
Compare
|
This patch can now land since vue-next v3.0.6 contains the necessary upstream fix. PR is green and already reviewed, so let's merge and fix #309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to spy on
wrapper.vmwith jest.Fixes #309
BLocked by vuejs/core#3105