Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly pass component definition as slot mounting option #743

Merged
merged 2 commits into from
Jul 8, 2021
Merged

fix: correctly pass component definition as slot mounting option #743

merged 2 commits into from
Jul 8, 2021

Conversation

lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Jul 8, 2021 •
edited
Loading

We were not passing the entire component to slots, just the render function, so things like the lifecycle hooks were not executed.

closes #727

@lmiller1990 lmiller1990 mentioned this pull request Jul 8, 2021
Closed
@lmiller1990 lmiller1990 changed the title repro 727 fix: correctly pass component definition as slot mounting option Jul 8, 2021
cexbrayat
cexbrayat approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@cexbrayat cexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cexbrayat cexbrayat merged commit 55b4707 into master Jul 8, 2021
@cexbrayat cexbrayat deleted the issue-727 branch July 8, 2021 07:06
@eunjae-lee
Copy link
Contributor

This looks good to me. Thank you 🙌🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cexbrayat cexbrayat cexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

lifecycle methods in child components not invoked
3 participants
@lmiller1990 @eunjae-lee @cexbrayat