Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added "Why vue" en, cn srt files into assets folder #1367

Merged
merged 3 commits into from
Jan 5, 2018
Merged

Added "Why vue" en, cn srt files into assets folder #1367

merged 3 commits into from
Jan 5, 2018

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Jan 4, 2018 •
edited
Loading

@Jinjiang Jinjiang requested a review from Justineo January 4, 2018 20:38
Justineo
Justineo reviewed Jan 5, 2018
View reviewed changes
assets/why-vue/chinese.js.srt

10
00:00:24,821 --> 00:00:27,829
Vue 是一款值得拥有的、多用途且高性能的
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“approachable”是“平易近人”的意思吧，这里用“友好的”？

assets/why-vue/english.js.srt
12
00:00:29,860 --> 00:00:33,381
a more maintainable,
and testable code base.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codebase 好像作为一个单词多一些？

assets/why-vue/english.js.srt

18
00:00:46,269 --> 00:00:48,240
into your frontend from the get go,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get-go

assets/why-vue/english.js.srt

38
00:01:33,673 --> 00:01:36,032
E L stands for element.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“el”（带引号）比较好吧，我理解不需要拆开的

assets/why-vue/english.js.srt

133
00:05:42,457 --> 00:05:44,708
I think you'll enjoy the View.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“enjoy the Vue”？

assets/why-vue/chinese.js.srt

108
00:04:31,860 --> 00:04:33,890
那一定很烦，所以如果我们想要
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“会很麻烦”？

assets/why-vue/chinese.js.srt

122
00:05:11,827 --> 00:05:15,828
使快速开启一个真实的工程变得非常简单
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“开启”有点奇怪，还是“初始化”？

assets/why-vue/chinese.js.srt

124
00:05:18,879 --> 00:05:21,770
它包含了各自的 HTML、JavaScrept
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JavaScript

assets/why-vue/chinese.js.srt

128
00:05:31,587 --> 00:05:33,065
Vue 可以做的一些皮毛的小事情
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“Vue 可以完成的工作中的皮毛”？“皮毛”一般当做名词用的吧。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“工作中的皮毛”感觉和原文的意思有一些距离了
或者用“Vue 能力的冰山一角”？

assets/why-vue/chinese.js.srt

131
00:05:36,555 --> 00:05:39,076
发展你的前端应用
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“scale”挺难翻，我建议译为“规模化”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉“规模化”比较晦涩了，我一开始也想到这个词，觉得用“发展”还OK吧

@chrisvfritz chrisvfritz merged commit 739471e into vuejs:master Jan 5, 2018
@kazupon kazupon mentioned this pull request Jan 6, 2018
Open
@Jinjiang Jinjiang deleted the why-vue branch January 6, 2018 19:05
sdras pushed a commit that referenced this pull request Jan 31, 2018
@lmiller1990 @sdras
[Cookbook] Unit Testing components (#1369)
813ab53 
* Create new page

* Update

* Improve intro

* Update

* Add Example

* Include real world example and explanation about testing

* Added "Why vue" en, cn srt files into assets folder (#1367)

* added english srt file

* added chinese srt file

* typo

* fix: Correct sidebar anchor targets (#1366)

Change function execution order to correct sidebar anchor targets; more concise fix to #1348.

* Images not found. (#1365)

Hi,
The images link for `hn.png` and `hn-architecture.png` can be found on `../../images/`.

* [Doc EN]: `event.md` add space to new part (#1363)

* New in with + symbol

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>

* Review of 2.5.0 doc

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>

* Review

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>

* Fix syntax typo

Signed-off-by: Bruno Lesieur <bruno.lesieur@gmail.com>

* Add space between new line of documentation

Signed-off-by: MachinisteWeb <bruno.lesieur@gmail.com>

* Add @posva review

Signed-off-by: MachinisteWeb <bruno.lesieur@gmail.com>

* Retrieve tweeningValue from onUpdate callback in documentation (#1350)

The tweeningValue no longer seems to be available in the tween object itself. Instead, the tweeningValue is available in the tweened object that passed as a parameter to the onUpdate callback.

* Add watch usages (#1356)

* Add watch usages!

Add `watch` usages!

* Update index.md

* tweaks to watch api examples

* Avoid updating license every year (#1353)

* Update spelling error and add some details about what we are testing

* Update

* typo for chinese subtitles of "why vue" video (#1371)

* Adding Why Vue.js video to Introduction page (#1377)

* Added video into guide introduction

* Added modal styles to page, put video line on one file, and reset iframe margin

* Fixed typo in Gulp example in deployment.md (#1376)

* Update deployment.md with Grunt example (#1375)

* Decoupled video player from Vimeo (#1374)

* Update Installation guide to use https://caniuse.com (#1372)

* [HOTFIX] initVideoModal error in common.js (#1378)

* Showing all possible params of watch() (#1380)

Surprised that the documentation didn't include the fact that the 2nd argument is the previous value. This can be really useful in some cases!

* refactor & update sponsors display

* include bronze data

* fix link

* fix link

* add build script

* update deploy docs

* Small fixes (#1381)

* fixed video modal bug in guide/index.md

* removed unnecessary sponsors content which has been in theme layout now

* fixed sponsors dropdown menu

* fixed button style in team page

* update Guillaume's core focus

* Improve based on Sarah Drasner feedback and fix some grammar

* Fixed TYPO Automatic Key Modifiers (#1388)

* update community deployment instructions

* Tweak wording of `.passive` modifier explanation

* Add guide link in Vue.filter API (#1394)

* Update filters, global filters needs to go before Vue instance creation (#1392)

Global filters defined after creating the Vue instance throws `Failed to resolve filter`. Reference https://forum.vuejs.org/t/global-filters-failing-to-resolve-inside-single-file-components/21863/6

* update tree-view example to add v-for key

* add details of object merging to mixins page

* Revise beforeUpdate API entry, fixes vuejs/vue#7481 (#1395)

* fix vue team distance sorting

* Add explicit version to download links (#1398)

* Add explicit version to download links

* improve CDN section of installation page

* demo from ’Object Change Detection‘ doesn't work (#1397)

vm.$set(this.userProfile, 'age', 27)    ==>   vm.$set(vm.userProfile, 'age', 27);

* Updated description of Weex (#1396)

* updated description of Weex (close #1382)

* Update comparison.md

* Update "incubated to" -> "incubated by"

* Update comparison.md

* Update comparison.md

* fix vue component require syntax for modern vue-loader

* The Web Optimization Project has optimized your repository! (#1389)

The Web Optimization Project optimized this repository. This commit contains the optimized files in this repository.

* Fix wrapperfind(error) typo and add example to test for whitespace

* Update

* Use factory function to save redundant logic

* Add factory function explanation and link to vue test utils guides.

* Update using codebryo feedback

* Change Github to GitHub (#1399)

* Fixed js error when click the page (#1401)

* Change cookbook entry number and reformat sentence

* Change order

* fix: typo in v-show description (#1408)

* Create new page

* Update

* Improve intro

* Update

* Add Example

* Include real world example and explanation about testing

* Update spelling error and add some details about what we are testing

* Update

* Improve based on Sarah Drasner feedback and fix some grammar

* Fix wrapperfind(error) typo and add example to test for whitespace

* Update

* Use factory function to save redundant logic

* Add factory function explanation and link to vue test utils guides.

* Update using codebryo feedback

* Change cookbook entry number and reformat sentence

* Change order

* Rebase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Justineo Justineo Justineo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jinjiang @Justineo @chrisvfritz