Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript version #1389

Closed
WORMSS opened this issue Aug 14, 2019 · 3 comments · Fixed by #1425
Closed

Update typescript version #1389

WORMSS opened this issue Aug 14, 2019 · 3 comments · Fixed by #1425

Comments

@WORMSS
Copy link

WORMSS commented Aug 14, 2019

It seems the version number for typescript inside vetur package.json is

"typescript": "^3.3.3333",

I was hoping I could get this upped to 3.5? Or 3.4 at the least?

I have valid code in my typescript files, and actually compiles correctly, but linting in .vue files reports that

class A {
  private readonly a: readonly string[] = [];
}

is invalid.
image

but no problem in .ts file
image

vscode 1.37.0
os: windows
vetur: 0.22.1

@octref
Copy link
Member

octref commented Aug 14, 2019

Pushed a branch to see if CI fails. If not we can update.

I just realized that I didn't document vetur.useWorkspaceDependencies, but if you set this to true Vetur will load TypeScript from your local workspace.

@WORMSS
Copy link
Author

WORMSS commented Aug 14, 2019

Thank you for the quick response and possibly quick resolution.
I will have a look at the useWorkspaceDependancies.
Hopefully it can work as a project level option so the whole team can benefit from it without having to get everyone to change settings.
But I will have to wait til I am back at work

@octref octref closed this as completed in ed9a8e5 Aug 14, 2019
octref added a commit that referenced this issue Aug 14, 2019
@ktsn ktsn reopened this Sep 10, 2019
@ktsn
Copy link
Member

ktsn commented Sep 10, 2019

VLS typescript version is not updated yet. #1422 (comment)

yoyo930021 pushed a commit to yoyo930021/vuter that referenced this issue Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants