Intellisense / type checking stopped working in v0.22.4 #1449

Soresu · 2019-10-04T12:30:05Z

I have searched through existing issues
I have read through docs
I have read FAQ

Info

Platform: Windows 10 x64
Vetur version: 0.22.4
VS Code version: 1.38.1
Already reinstalled Visual Studio Code, Vetur
Happens on multiple PC
Tried to remove other plugins

Problem

Intellisense stopped working properly in Vue files. Although it works in the first opened vue file or if it was opened in the previous session.
Downgrading to Vetur 0.22.3 fixed the issue.

Reproducible Case

Close all tabs in the current project
Close and open Visual Studio Code
Open a vue file
Wait until the plugins are loaded
Hovering over/Ctrl+space at imported objects, variables doesn't show any info
Close and open Visual Studio Code
Intellisense works in the previously opened file

borradaniele · 2019-10-04T13:17:49Z

Same here, linking between files does not work with cmd and intellisense does not shows up, already tried to uninstall and reinstall.
Seems like occasionally it starts working again for some times and then stops again, not sure about the events chain that causes this tho.

Platform: Mac OS Mojave 10.14.6
VS Code version: 1.38.1
Vetur version: 0.22.4

If you need more info or log let me know.

alexsasharegan · 2019-10-04T17:00:07Z

Same on Linux.

Vetur: 0.22.4

VSCode Stats:
Version: 1.38.1
Commit: b37e54c98e1a74ba89e03073e5a3761284e3ffb0
Date: 2019-09-11T13:30:08.229Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Linux x64 5.0.0-31-generic

yoyo930021 · 2019-10-05T15:02:02Z

#1317 (comment)
+1

Sheng-Long · 2019-10-08T00:54:43Z

Same issue for me, although it always seems to work in at least one file, but not the others

hkk2018 · 2019-10-09T09:50:13Z

+1

matthew-ch · 2019-10-10T06:58:11Z

Similar issue for my project using typescript.

VSCode version: 1.39.0
OS: macOS Catalina 10.15
Vetur version: 0.22.4

Downgrading to 0.22.3 works.

Ttou · 2019-10-11T05:49:31Z

+1

sppera · 2019-10-11T06:29:54Z

+1

Platform: Linux fedora 5.2.18-200.fc30.x86_64
Vetur version: 0.22.4
VS Code version: 1.39.1

wfischer42 · 2019-10-13T02:58:04Z

Similar issue.
Specifically, TypeScript errors only show up in the first file I open after launching VSCode.
This was true using both TSLint Vue and ESLint to validate.

Downgrading to 0.22.3 worked for me too.

SunshowerC · 2019-10-15T03:25:12Z

same here.
Platform: Mac
Vetur version: 0.22.4

imakan · 2019-10-15T08:26:47Z

Downgrading to 0.22.3 worked for me

Yancy1028 · 2019-10-16T06:22:21Z

my english is bad,but I know how to reproduce the problem.
in my new application,
1st use any "*.vue" file in "router.ts",and close all opened vue file,
2nd resert VSCode,and then open a normal vue file,that's ok,
3rd open any one vue file is "router.ts" used.that is not work.

it's look like ,vue file is import on other *".ts" file,vue IntelliSense not work.

amirafzali · 2019-10-16T06:32:12Z

Platform: Mac
Vetur version: 0.22.4

Only one file has working intellisense at a given time. Language server keeps crashing.
Downgrading to 0.22.3 fixed the problem.

rchl · 2019-10-16T08:08:43Z

Guys, there is no need for more confirmations. Just use the reaction icon if you need to say "me too"

tomasbjerre · 2019-10-16T12:07:36Z

Same here. It works for a while after reinstall.
Workaround: CTRL-P and type: > Reinstall Extension and pick Vetur.

petternordholm · 2019-10-16T12:31:02Z

Hi!

Did some debugging on this issue. AFAIK, the problem is related to:
javascript.ts:languageServiceIncludesFile

This method is called with the .vue file and return false. This will bypass validation, hovering, etc. and return an empty result.

For instance:

    doValidation(doc: TextDocument): Diagnostic[] {
      const { scriptDoc, service } = updateCurrentVueTextDocument(doc);
      if (!languageServiceIncludesFile(service, doc.uri)) {
        return [];
      }

In our tsconfig.json, we are not including vue file since these will be pulled in by the compiler anyway when our entry point ts files are compiled.

So,

export function languageServiceIncludesFile(ls: ts.LanguageService, documentUri: string): boolean {
  const filePaths = ls.getProgram()!.getRootFileNames();
  const filePath = getFilePath(documentUri);
  const found = filePaths.includes(filePath);
  return found;
}

filePaths will not contain our vue files, only ts files, and the method will return false.

yoyo930021 · 2019-10-16T12:32:49Z

Hi!

Did some debugging on this issue. AFAIK, the problem is related to:
javascript.ts:languageServiceIncludesFile

This method is called with the .vue file and return false. This will bypass validation, hovering, etc. and return an empty result.

For instance:
    doValidation(doc: TextDocument): Diagnostic[] {
      const { scriptDoc, service } = updateCurrentVueTextDocument(doc);
      if (!languageServiceIncludesFile(service, doc.uri)) {
        return [];
      }
In our tsconfig.json, we are not including vue file since these will be pulled in by the compiler anyway when our entry point ts files are compiled.

So,
export function languageServiceIncludesFile(ls: ts.LanguageService, documentUri: string): boolean {
  const filePaths = ls.getProgram()!.getRootFileNames();
  const filePath = getFilePath(documentUri);
  const found = filePaths.includes(filePath);
  return found;
}
filePaths will not contain our vue files, only ts files, and the method will return false.

#1450 PR will fixed.

petternordholm · 2019-10-16T12:37:45Z

Kudos @yoyo930021 .. Great work! Hope we can get this PR merged ASAP!

It is driving me crazy. I will apply your changes on my local VLS

josh-hemphill · 2019-10-17T19:45:25Z

I want to make sure this is my only issue, did this also break all emmet/bracket-closing functions as well?

tomasbjerre · 2019-10-18T05:18:16Z

If anyone wants to install a previous version, you can install it like this:

octref · 2019-10-21T15:49:44Z

Should be fixed in 0.22.5. Thanks to @yoyo930021 for fixing it! Sorry I had been traveling and just catching up with notifications.

GordonBlahut · 2019-10-21T20:08:34Z

0.22.5 still doesn't fix this for me. Downgrading to 0.22.3 works.

Windows 10 x64, VS Code 1.39.2
Tried uninstalling Vetur, deleting from extensions directory and reinstalling.

octref · 2019-10-21T23:13:32Z

@GordonBlahut Does it reproduce on the sample project? https://github.com/octref/veturpack
If not, can you open a new bug report with reproducible steps?

douglasg14b · 2019-10-22T00:16:21Z

I'm also having this issue, v0.22.4 & 0.22.5 both have this issue for me.

Manually downgrading to v0.22.3 resolves it.

douglasg14b · 2019-10-22T00:17:45Z

Why is the issue closed?

Neme12 · 2019-10-22T07:11:59Z

I'm still encountering this issue after upgrading to 0.22.5. In fact it no longer works even in the first opened file.

matthew-ch · 2019-10-22T08:06:51Z

For me version 0.22.5 works, both in ts and non-ts projects.

deankinane · 2019-10-22T10:12:04Z

InelliSense now completely broken in 0.22.5.
Doesn't work in first open file or file opened from previous session.

Have tested both TS and JS and neither work.

Downgrading to 0.22.4 fixes the issue for the first opened file.

Downgrading to 0.22.3 fixes the issue for all files.

Environment details:
VS Code: 1.39.2
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.17134

Soresu · 2019-10-22T10:32:03Z

The new 0.22.5 still has the problem. Moreover, step 7 of the reproducible case is now broken too.

yoyo930021 · 2019-10-22T10:59:05Z

I think to have another problem causes on this issue.
Maybe #1469

If (use windows OS and broken) {
    pick +1 reaction.
} else {
    pick -1 reaction.
}

@Soresu @Neme12 @douglasg14b @GordonBlahut

yoyo930021 · 2019-10-22T13:04:15Z

I think have an error fix in #1450.

I fix it on #1472.
Have anyone can verify it?

praveenpuglia · 2019-10-22T16:56:17Z

I don't know. I used 0.22.5 for most part of the day today. Haven't seen problems. Help me see the problem?

petternordholm · 2019-10-23T06:52:59Z

I don't know. I used 0.22.5 for most part of the day today. Haven't seen problems. Help me see the problem?

@praveenpuglia I think the problem is related to windows and windows filepaths. Are you running VSCode on linux or mac ?

praveenpuglia · 2019-10-23T07:38:18Z

macOS Catalina - 10.15

octref · 2019-10-23T19:58:51Z

Fix for Windows is released on 0.22.6.

Soresu · 2019-10-23T20:59:24Z

@octref Seems like 0.22.6 fixed the issue.

lzinga · 2019-12-03T02:47:42Z

I believe I am still getting this issue. I have been able to get the import intellisense paths to work by using this post on reddit. However when I try to access anything from the imported file there is no intellisense.
Inside the imported file the following exists.

import axios from 'axios'

export const test = {
	async get(id) {
		// ..
	}
}

Intellisense doesn't even exist for any Vue elements either. I am at a complete halt in my development because of this issue that I can't seem to get past. I am somewhat new to dealing with js but have been programming for quite a few years now and have been frustrated for over a week now.

yoyo930021 · 2019-12-03T02:50:31Z

@lzinga please give more info for this.
Create new issue, and use issue template.

Niekvdm · 2020-02-05T10:14:12Z

Issue arrised again in 0.23.0 see #1589

ykamal · 2020-05-11T23:04:50Z

Bumping this. Same problem. Suddenly stopped working.
Version: 1.45.0 (user setup)
Commit: d69a79b73808559a91206d73d7717ff5f798f23c
Date: 2020-05-07T16:18:48.860Z
Electron: 7.2.4
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.18363
Installing/Reinstalling Vetur didn't help.

yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Oct 7, 2019

Fix vuejs#1449

8951599

yoyo930021 mentioned this issue Oct 7, 2019

Fix intellisense and other features when open multiple files #1450

Merged

rchl mentioned this issue Oct 7, 2019

vls v0.0.62 seems to be broken sublimelsp/LSP-vue#10

Closed

sploders101 mentioned this issue Oct 9, 2019

Cannot work with flow #1452

Closed

3 tasks

Ky6uk mentioned this issue Oct 11, 2019

TypeScript errors not showing after upgrading VSCode to v1.39 #1456

Closed

3 tasks

ktsn changed the title ~~Intellisense stopped working in the new version~~ Intellisense / type checking stopped working in v0.22.4 Oct 14, 2019

ktsn added the bug label Oct 14, 2019

yoyo930021 mentioned this issue Oct 19, 2019

No completions in typescript #1464

Closed

zoton2 mentioned this issue Oct 20, 2019

Improve TypeScript in Vue.js code speedcontrol/nodecg-speedcontrol#58

Closed

octref closed this as completed in #1450 Oct 21, 2019

octref added a commit that referenced this issue Oct 21, 2019

Changelog for #1449

8649460

deankinane mentioned this issue Oct 22, 2019

can't jump to other file from the import statement in vue file #1468

Closed

3 tasks

Soresu mentioned this issue Oct 22, 2019

No Intellisense for new exports #1471

Closed

3 tasks

yoyo930021 mentioned this issue Oct 22, 2019

Fix add to scriptFileNameSet path format #1472

Merged

octref mentioned this issue Oct 22, 2019

No more typescript errors showing in 0.22.5 #1473

Closed

3 tasks

oskarkunik mentioned this issue Feb 4, 2020

Vue Language Server crash in 0.23.0 #1656

Closed

3 tasks

Intellisense / type checking stopped working in v0.22.4 #1449

Intellisense / type checking stopped working in v0.22.4 #1449

Comments

Soresu commented Oct 4, 2019

Info

Problem

Reproducible Case

borradaniele commented Oct 4, 2019

alexsasharegan commented Oct 4, 2019

yoyo930021 commented Oct 5, 2019 • edited Loading

Sheng-Long commented Oct 8, 2019

hkk2018 commented Oct 9, 2019

matthew-ch commented Oct 10, 2019

Ttou commented Oct 11, 2019

sppera commented Oct 11, 2019

wfischer42 commented Oct 13, 2019

SunshowerC commented Oct 15, 2019

imakan commented Oct 15, 2019

Yancy1028 commented Oct 16, 2019

amirafzali commented Oct 16, 2019

rchl commented Oct 16, 2019 • edited Loading

tomasbjerre commented Oct 16, 2019

petternordholm commented Oct 16, 2019

yoyo930021 commented Oct 16, 2019

petternordholm commented Oct 16, 2019

josh-hemphill commented Oct 17, 2019

tomasbjerre commented Oct 18, 2019

octref commented Oct 21, 2019

GordonBlahut commented Oct 21, 2019

octref commented Oct 21, 2019

douglasg14b commented Oct 22, 2019 • edited Loading

douglasg14b commented Oct 22, 2019

Neme12 commented Oct 22, 2019

matthew-ch commented Oct 22, 2019

deankinane commented Oct 22, 2019 • edited Loading

Soresu commented Oct 22, 2019

yoyo930021 commented Oct 22, 2019 • edited Loading

yoyo930021 commented Oct 22, 2019 • edited Loading

praveenpuglia commented Oct 22, 2019

petternordholm commented Oct 23, 2019

praveenpuglia commented Oct 23, 2019 • edited Loading

octref commented Oct 23, 2019

Soresu commented Oct 23, 2019

lzinga commented Dec 3, 2019

yoyo930021 commented Dec 3, 2019

Niekvdm commented Feb 5, 2020

ykamal commented May 11, 2020

yoyo930021 commented Oct 5, 2019 •

edited

Loading

rchl commented Oct 16, 2019 •

edited

Loading

douglasg14b commented Oct 22, 2019 •

edited

Loading

deankinane commented Oct 22, 2019 •

edited

Loading

yoyo930021 commented Oct 22, 2019 •

edited

Loading

yoyo930021 commented Oct 22, 2019 •

edited

Loading

praveenpuglia commented Oct 23, 2019 •

edited

Loading