Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The props validator can't handle about v-bind, :[key] and v-model #2236

Closed
1 task done
yoyo930021 opened this issue Sep 4, 2020 · 2 comments · Fixed by #2241
Closed
1 task done

The props validator can't handle about v-bind, :[key] and v-model #2236

yoyo930021 opened this issue Sep 4, 2020 · 2 comments · Fixed by #2241

Comments

@yoyo930021
Copy link
Member

yoyo930021 commented Sep 4, 2020

  • I have searched through existing issues

Feature Request

The v-bind is hard to handle.
Maybe we can ignore it.

The :[key] is also hard to handle.

The v-model can read AST to handle.

@yoyo930021 yoyo930021 changed the title The props validator can't handle about v-bind and v-model The props validator can't handle about v-bind, :[attr] and v-model Sep 4, 2020
@yoyo930021 yoyo930021 changed the title The props validator can't handle about v-bind, :[attr] and v-model The props validator can't handle about v-bind, :[key] and v-model Sep 4, 2020
yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
yoyo930021 added a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
octref pushed a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
octref pushed a commit to yoyo930021/vuter that referenced this issue Sep 4, 2020
octref pushed a commit to yoyo930021/vuter that referenced this issue Sep 6, 2020
octref pushed a commit to yoyo930021/vuter that referenced this issue Sep 6, 2020
@bbugh
Copy link

bbugh commented Sep 6, 2020

@octref #2241 does not appear to address custom model names. The model prop can be customized, but if I'm reading the source correctly, the model prop in that change set seems to be hard-codes to value. From the docs: https://vuejs.org/v2/api/#model

@yoyo930021
Copy link
Member Author

yoyo930021 commented Sep 7, 2020

@octref #2241 does not appear to address custom model names. The model prop can be customized, but if I'm reading the source correctly, the model prop in that change set seems to be hard-codes to value. From the docs: https://vuejs.org/v2/api/#model

No, #2241 has thought about it.
Please see code https://github.com/vuejs/vetur/blob/master/server/src/modes/script/componentInfo.ts#L117
and test https://github.com/vuejs/vetur/blob/master/test/interpolation/fixture/diagnostics/propsValidation/object-validator-props-child.vue#L3

cereschen pushed a commit to cereschen/vetur that referenced this issue Sep 10, 2020
cereschen pushed a commit to cereschen/vetur that referenced this issue Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants