Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-checking broken with TypeScript 4.5.x+ #3323

Closed
4 tasks done
rchl opened this issue Jan 27, 2022 · 8 comments
Closed
4 tasks done

Type-checking broken with TypeScript 4.5.x+ #3323

rchl opened this issue Jan 27, 2022 · 8 comments

Comments

@rchl
Copy link
Collaborator

rchl commented Jan 27, 2022

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ
  • I have tried restarting VS Code or running Vetur: Restart VLS

Info

  • Platform: macOS
  • Vetur version: v0.35.0
  • VS Code version: 1.63.2

Problem

When using workspace dependencies with typescript version 4.5.2 or higher, type checking doesn't work correctly in the template or script block.

Reproducible Case

  1. Clone https://github.com/rchl/vetur-ts45
  2. Set vetur.useWorkspaceDependencies in VSCode's User preferences (it's not available in Workspace preferences).
  3. Open the project and the src/Test.vue file.

The issue exists since typescript v4.5.2. Downgrading to typescript v4.4.4 works as expected.
There are no public (stable) versions of typescript in between those.

Result:

Screenshot 2022-01-27 at 18 36 10

Expected

Screenshot 2022-01-27 at 18 36 49

@ascott18
Copy link

ascott18 commented Feb 16, 2022

Issue is also present with Typescript 4.5.5.

image

For searchability:

  • 'this' implicitly has type 'any' because it does not have a type annotation. Vetur(2683)
  • Duplicate identifier '(Missing)'. Vetur(2300)
  • Cannot find name '__vlsRenderHelper'. Vetur(2304)
  • Cannot find name '__vlsComponentHelper'. Vetur(2304)

Ken-Miura added a commit to Ken-Miura/career_change_supporter that referenced this issue Mar 3, 2022
@mrfy
Copy link

mrfy commented Apr 15, 2022

Same here

@ccaspers
Copy link

ccaspers commented Apr 28, 2022

same for typescript 4.6.3

@kberg
Copy link

kberg commented Jul 10, 2022

Unless I'm mistaken, the last commit to this repository was in November. It's a sign that there's no activity in public, and implies there might not be activity behind the scenes. I wonder what's going on.

@yoyo930021 yoyo930021 mentioned this issue Jul 11, 2022
8 tasks
@rchl
Copy link
Collaborator Author

rchl commented Jul 11, 2022

@yoyo930021 this doesn't appear to be fixed with 0.8.0 release:

Screenshot 2022-07-11 at 09 26 50

yoyo930021 added a commit that referenced this issue Jul 11, 2022
@yoyo930021
Copy link
Member

@yoyo930021 this doesn't appear to be fixed with 0.8.0 release:

Screenshot 2022-07-11 at 09 26 50

I'm sorry. It is a careless mistake.
You can test the 0.8.1 release in vls and 0.1.7 in vti.

The VSCode extension will update when I get permission again.
My token is expired.....

@rchl
Copy link
Collaborator Author

rchl commented Jul 11, 2022

Looks good now. Thanks for the fix!

@kberg
Copy link

kberg commented Jul 12, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants