feat: remove vuetify-helper-json and use runtime pkg info #1365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekosaur
force-pushed
the
feat/vuetify-completion
branch
from
58dba21 to
05b0fe7
Compare
nekosaur
force-pushed
the
feat/vuetify-completion
branch
from
05b0fe7 to
4056e3d
Compare
kevinmarrec
suggested changes
Aug 6, 2019
| settings['vuetify'] = true; | ||
| } | ||
| if (dependencies['@nuxtjs/vuetify'] || devDependencies['@nuxtjs/vuetify']) { | ||
| dependencies['vuetify'] = true; |
There was a problem hiding this comment.
Shouldn't it be :
Suggested change
| dependencies['vuetify'] = true; | |
| settings['vuetify'] = true; |
?
There was a problem hiding this comment.
No. I am not actually 100% sure what setting the settings object accomplishes 😕 . And since settings[dep] = true is executed later anyway, it shouldn't matter.
The actual loading of the autocomplete data specified in vetur package.json option happens here
dependencies object. Since vuetify is not a direct dependency when using nuxtjs module, we fake it by inserting vuetify.
There was a problem hiding this comment.
Good catch, then all good I believe
|
LGTM, thanks! |
|
Thanks again! 💚 |
yoyo930021
pushed a commit
to yoyo930021/vuter
that referenced
this pull request
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switched to using
veturoption inside package.json for auto-completion instead of separate package.also added support through @nuxtjs/vuetify package