Highlight directives containing numbers #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octref
force-pushed
the
highlight-directive-numbers
branch
from
36ae24b
to
6ebc0de
Compare
|
Old build failed and is gone. I rebased and added some test. |
|
Good job. Thank you! |
|
Thanks again! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently directives are not correctly highlighted if their names contain numbers. This makes templates containing "dynamic SVG" pretty unreadable as the names of many SVG attributes (
x1,k1,in2, etc.) contain numbers. Changing the pattern to allow digits in the directive name fixes this problem:I know that the Vue grammar is technically not meant to encompass SVG, but I don't see how this change negatively affects HTML highlighting.