Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no props completion when child component export default {} ends with ; #1791

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Fix no props completion when child component export default {} ends with ; #1791

merged 2 commits into from
Jul 31, 2020

Conversation

yoyo930021
Copy link
Member

@yoyo930021 yoyo930021 commented Mar 19, 2020 •
edited
Loading

Fixed #1775

@yoyo930021 yoyo930021 mentioned this pull request Mar 19, 2020
Closed
@yoyo930021 yoyo930021 changed the title Fix no props completion when child component isn't end of export default {} Fix no props completion when child component is end of ; Mar 19, 2020
@yoyo930021 yoyo930021 changed the title Fix no props completion when child component is end of ; Fix no props completion when child component export default {} is end of ; Mar 19, 2020
@yoyo930021 yoyo930021 changed the title Fix no props completion when child component export default {} is end of ; Fix no props completion when child component export default {} is end of ; Mar 19, 2020
@yoyo930021
Copy link
Member Author

Hi anyone, I publish self-maintenance vscode extension.
This extension will be maintained until Vetur is reactivated.

https://marketplace.visualstudio.com/items?itemName=yoyo930021.vuter

@F0rsaken
Copy link

Hi anyone, I publish self-maintenance vscode extension.
This extension will be maintained until Vetur is reactivated.

https://marketplace.visualstudio.com/items?itemName=yoyo930021.vuter

This should be linked in README.md or idk, in issues, 'cause it's life saver <3

@octref octref changed the title Fix no props completion when child component export default {} is end of ; Fix no props completion when child component export default {} ends with ; Jul 31, 2020
octref
octref approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job to track it down. Who would have thought about ; affecting it 🤷‍♂️

@octref octref merged commit c086537 into vuejs:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no props completion when child component export default {} ends with ;
3 participants
@yoyo930021 @F0rsaken @octref