Fix object property completion when have hyphen #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoyo930021
force-pushed
the
fix-hyphen-completion
branch
from
91f63a6
to
76e5ddf
Compare
yoyo930021
changed the title
yoyo930021
force-pushed
the
fix-hyphen-completion
branch
from
76e5ddf
to
02208d8
Compare
This comment has been minimized.
This comment has been minimized.
yoyo930021
force-pushed
the
fix-hyphen-completion
branch
from
02208d8
to
22e5ff1
Compare
octref
force-pushed
the
fix-hyphen-completion
branch
from
22e5ff1
to
1707726
Compare
|
I have a simpler fix. The ranking is not preserved but that's a VS Code issue: microsoft/vscode#103682 |
octref
reviewed
Jul 31, 2020
| return { | ||
| uri: doc.uri, | ||
| position, | ||
| preselect: entry.isRecommended ? true : undefined, |
There was a problem hiding this comment.
I'll split this into another commit...Let one PR do one thing, don't include unrelated changes, or it becomes harder to review. Thanks!
| const { label, detail } = calculateLabelAndDetailTextForPathImport(entry); | ||
| const kind = toCompletionItemKind(entry.kind); | ||
| const insertTextFormat = | ||
| kind === CompletionItemKind.Function || kind === CompletionItemKind.Method |
There was a problem hiding this comment.
In VS Code this is behind typescript.suggest.completeFunctionCalls which defaults to false. I don't think we should turn this on by default.
| kind === CompletionItemKind.Function || kind === CompletionItemKind.Method | ||
| ? InsertTextFormat.Snippet | ||
| : undefined; | ||
| const insertText = entry.insertText || entry.name; |
There was a problem hiding this comment.
No need to do this. If entry.insertText is undefined just pass it in.
|
I think it's ok to merge now. The |
octref
added a commit
that referenced
this pull request
Jul 31, 2020
octref
added a commit
that referenced
this pull request
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1804