Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1484 #2161

Merged
merged 1 commit into from
Aug 14, 2020
Merged

Fix #1484 #2161

merged 1 commit into from
Aug 14, 2020

Conversation

cereschen
Copy link
Contributor

No description provided.

@cereschen cereschen closed this Aug 14, 2020
@cereschen
Copy link
Contributor Author

still have bug

@cereschen
Copy link
Contributor Author

cereschen commented Aug 14, 2020

For example
<span v-for="item in items" v-text="item" />
Find definitions for item is not work well
Even report an error
But I can't fix this right now

@cereschen cereschen reopened this Aug 14, 2020
@octref
Copy link
Member

octref commented Aug 14, 2020

Maybe you are running into #2167. Otherwise this looks good to me and makes the URI handlign consistent with javascript.ts.

Since JS jump to definition is working for people so this should work across macOS / Windows as well.

Thanks for your contribution 👍

@cereschen
Copy link
Contributor Author

Maybe you are running into #2167. Otherwise this looks good to me and makes the URI handlign consistent with javascript.ts.

Since JS jump to definition is working for people so this should work across macOS / Windows as well.

Thanks for your contribution 👍

I mean, the variables created in the v-for directive can't find the definition correctly
But it seems that this is a problem that can be ignored
Vetur is a great extension, and I hope to help improve the user experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants