Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collapse code missing end mark #2352

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Fix collapse code missing end mark #2352

merged 2 commits into from
Oct 7, 2020

Conversation

yoyo930021
Copy link
Member

Fixed #2303

@yoyo930021 yoyo930021 force-pushed the add-collapse-end-in-ts branch from 1047ac5 to 7eb3c5d Compare October 5, 2020 12:43
@yoyo930021 yoyo930021 force-pushed the add-collapse-end-in-ts branch from 7eb3c5d to b14851c Compare October 7, 2020 13:09
@yoyo930021
Copy link
Member Author

I rebase. but the test is failed in master commit.

@octref
Copy link
Member

octref commented Oct 7, 2020

Master is green again.

@octref octref closed this Oct 7, 2020
@octref octref reopened this Oct 7, 2020
octref
octref approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@octref octref left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job finding VS Code's implementation! We can always learn from typescript-language-features and html-language-features to keep the features consistent with VS Code's implementation 👍

@octref octref merged commit 8ee5f21 into vuejs:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octref octref octref approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collapse code missing end mark
2 participants
@yoyo930021 @octref