Add slim syntax highlighting #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lovely 👍 |
octref
force-pushed
the
add-slim-support
branch
from
215e108
to
69f0a65
Compare
octref
approved these changes
Oct 30, 2020
yoyo930021
reviewed
Jan 11, 2021
| @@ -6,6 +6,49 @@ | |||
| ], | |||
| "uuid": "5512c10d-4cc5-434c-b8fc-53b912f55ab3", | |||
| "patterns": [ | |||
| { | |||
There was a problem hiding this comment.
@Antti
I notice this block code.
it isn't generated from yaml.
Is this code necessary?
There was a problem hiding this comment.
@yoyo930021 I have only edited the YAML file and run the generator, so I believe it was generated from it. At least at that point in time.
There was a problem hiding this comment.
That's weird.
Now when running will disappear.
I don't think it should be necessary and I will remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Slim syntax highlighting via Slim extension