Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

language-c# missing 'line-numbers-mode' class #1352

Closed
3 tasks done
lslzl3000 opened this issue Sep 17, 2022 · 2 comments · Fixed by #1353
Closed
3 tasks done

language-c# missing 'line-numbers-mode' class #1352

lslzl3000 opened this issue Sep 17, 2022 · 2 comments · Fixed by #1353
Labels
build Related to the build system

Comments

@lslzl3000
Copy link

lslzl3000 commented Sep 17, 2022 •
edited
Loading

Describe the bug

I have enabled lineNumbers option in config
The ts, html, js works fine

But the c# is missing line-numbers-mode class so that losing padding-left style
Screen Shot 2022-09-17 at 20 39 53

Is this a bug? maybe the # problem?

By vitepress-1.0.0-alpha.15

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@lslzl3000 lslzl3000 added the bug: pending triage Maybe a bug, waiting for confirmation label Sep 17, 2022
@lslzl3000 lslzl3000 changed the title markdown language-c# missing 'line-numbers-mode' class language-c# missing 'line-numbers-mode' class Sep 17, 2022
@brc-dd brc-dd added bug build Related to the build system and removed bug: pending triage Maybe a bug, waiting for confirmation labels Sep 17, 2022
@brc-dd
Copy link
Member

brc-dd commented Sep 17, 2022

Is this a bug? maybe the # problem?

Yeah. This regex needs to be updated:

vitepress/src/node/markdown/plugins/lineNumbers.ts

Line 24 in 50f4105

.replace(/"(language-[-\w]*)"/, '"$1 line-numbers-mode"')

@sun0day
Copy link
Contributor

sun0day commented Sep 17, 2022

I can offer a PR @brc-dd

sun0day pushed a commit to sun0day/vitepress that referenced this issue Sep 17, 2022
fix: code language compatible with special char (fix vuejs#1352)
30b57f5
@sun0day sun0day mentioned this issue Sep 17, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
build Related to the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): line numbers mode when language specifier has symbol sun0day/vitepress
3 participants
@lslzl3000 @brc-dd @sun0day