Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale Config: Specify the path of the homepage on the logo #1682

Closed
3 tasks done
PierW opened this issue Dec 9, 2022 · 3 comments
Closed
3 tasks done

Locale Config: Specify the path of the homepage on the logo #1682

PierW opened this issue Dec 9, 2022 · 3 comments
Labels
bug: pending triage Maybe a bug, waiting for confirmation

Comments

@PierW
Copy link

PierW commented Dec 9, 2022

Describe the bug

If we have a multilingual project the path inside the href attribute for logo element doesn't change!
For example if I try to change from italian to english I have always: href="/" when I expect to find href="/en/
For Vuepress V2 we have the "home" settings . But for Vitepress?

Reproduction

  1. Create a multilingual project.
  2. Click on the logo link

Expected behavior

Redirect to the respective locale.

System Info

Macbook Pro M2, Chrome

Additional context

No response

Validations

  • Follow our Code of Conduct
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
@PierW PierW added the bug: pending triage Maybe a bug, waiting for confirmation label Dec 9, 2022
@brc-dd
Copy link
Member

brc-dd commented Jan 2, 2023

Multilingual projects are not yet supported. Track #631.

@brc-dd brc-dd closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2023
@PierW
Copy link
Author

PierW commented Jan 18, 2023

@brc-dd I think that we can close this issue, from yesterday the Pr was merged! 🚀🎉
In these days I will check if it's works fine.

@brc-dd
Copy link
Member

brc-dd commented Jan 18, 2023

Yeah sure, just create a new one if something appears to be broken. 🙌

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug: pending triage Maybe a bug, waiting for confirmation
Projects
None yet
Development

No branches or pull requests

2 participants