Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): allow moving aside to left #2138

Merged
merged 11 commits into from
Mar 27, 2023
Merged

feat(theme): allow moving aside to left #2138

merged 11 commits into from
Mar 27, 2023

Conversation

JohnCampionJr
Copy link
Contributor

@JohnCampionJr JohnCampionJr commented Mar 25, 2023

closes #2035

Made it as unobtrusive as I could think of. Simply set aside to left in frontmatter and it changes.

Made it as unobtrusive as I could think of.
@JohnCampionJr JohnCampionJr changed the title Closes #2035: Adds left aside option feat(theme): Closes #2035: Adds left aside option Mar 25, 2023
@JohnCampionJr
Copy link
Contributor Author

I couldn't find anywhere in the docs to update this one, so I fixed up the types instead

brc-dd

This comment was marked as resolved.

JohnCampionJr and others added 3 commits March 27, 2023 13:56
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
@brc-dd brc-dd changed the title feat(theme): Closes #2035: Adds left aside option feat(theme): allow keeping aside on left Mar 27, 2023
@brc-dd brc-dd changed the title feat(theme): allow keeping aside on left feat(theme): allow moving aside to left Mar 27, 2023
@JohnCampionJr
Copy link
Contributor Author

Tested locally :)

@JohnCampionJr
Copy link
Contributor Author

Improved the docs and the types to clearly explain what happens :)

JohnCampionJr and others added 2 commits March 27, 2023 15:02
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
@brc-dd brc-dd merged commit 9e3cf0f into vuejs:main Mar 27, 2023
@JohnCampionJr JohnCampionJr deleted the left-aside branch March 27, 2023 19:13
@haiting
Copy link

haiting commented Mar 28, 2023

Is that feature release ?

@brc-dd
Copy link
Member

brc-dd commented Mar 28, 2023

@haiting Yeah it will be there in alpha.64

@haiting
Copy link

haiting commented Mar 28, 2023

Thx! And do you mind if I know the schedule?

@brc-dd
Copy link
Member

brc-dd commented Mar 28, 2023

2-3 days

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Outline] Add support for left or right positioned Outline
3 participants