-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme): allow moving aside to left #2138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made it as unobtrusive as I could think of.
I couldn't find anywhere in the docs to update this one, so I fixed up the types instead |
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
brc-dd
reviewed
Mar 27, 2023
Tested locally :) |
brc-dd
approved these changes
Mar 27, 2023
Improved the docs and the types to clearly explain what happens :) |
brc-dd
reviewed
Mar 27, 2023
brc-dd
reviewed
Mar 27, 2023
Co-authored-by: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Is that feature release ? |
@haiting Yeah it will be there in alpha.64 |
Thx! And do you mind if I know the schedule? |
2-3 days |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2035
Made it as unobtrusive as I could think of. Simply set aside to left in frontmatter and it changes.