-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding link to (non-html) files from md #265
Comments
I just ran into the same issue. I am also trying to link to a pdf file. |
Ah good point. Wasn't thinking about this use case. Hmmm should we have whitelist to filter out major extensions? |
@kiaking Yeah, that could be a nice solution. The actual extensions may differ for different sites significantly – some may share books, others provide 3d models and so on. So there may be an option in config.js file with some default state with the list of most used file extensions. |
That would be a great solution. Thanks for thinking about it. |
@kiaking @jarrodu I'm deep into vitepress now and have many ideas on improving it, but can't figure out where to discuss them. Vue discord has a vitepress channel, but it's quite silent. I think vitepress may become a great tool for users to create and publish their digital gardens (which are quite a hype now!). I have my little snippets running for the purpose and I'll be glad to share these ideas and collaborate on implementing them. |
I have not worked on this issue. Since I am using vitepress for a personal project this issue is not urgent. Are you thinking of picking up the issue? |
It's ok. ) I have a couple of workarounds for this issue with custom components just for the cases. Vitepress is so flexible, so any problem is solvable with a nice SFC )))) |
Vitepress keeps adding
.html
extension to any link referencing a pdf file relative to the page. Seems like it's hard-coded herevitepress/src/node/markdownToVue.ts
Line 52 in cee0b40
May be it's the right way and any non-routed link should be put as
<a>
tag? Just wanted to share this observation.The text was updated successfully, but these errors were encountered: