Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): outline marker flicks when navigating towards above #2676

Closed
wants to merge 1 commit into from

Conversation

zonemeen
Copy link
Collaborator

fix #2665

@brc-dd brc-dd force-pushed the main branch 2 times, most recently from 7ad4a4e to f0d3082 Compare August 3, 2023 10:20
@xsjcTony
Copy link
Contributor

xsjcTony commented Aug 3, 2023

👀

@brc-dd
Copy link
Member

brc-dd commented Aug 3, 2023

I don't think this exactly fixes the bug. Sure reduces it by some factor 👀

ezgif-5-c0f4a050cb.mov

(at 0.5x slowdown)

Also, removing debouncing completely is not a good solution. This currently takes 1-2ms each time the scroll event fires (and scroll fires a lot!).

For most of the times that "flick" is not much noticeable. (Honestly, to me, that always seemed like cool easeOutBack transition. 😅)

@zonemeen
Copy link
Collaborator Author

zonemeen commented Aug 4, 2023

If the time between two clicks is too short, the flick is obvious. This problem was introduced by #2527. Since the two requestAnimationFrames are triggered almost simultaneously, and then one of them was delayed, resulting in a flick.

I guess need to modify the implementation of #2527 to avoid using two requestAnimationFrames.🤔

@brc-dd brc-dd closed this in e8ebf1b Aug 7, 2023
@zonemeen zonemeen deleted the fix/flick branch August 7, 2023 10:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞Bug: aside's outline marker is flicking when navigating towards above
3 participants