Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: textual code copy/paste feature #3046

Closed
wants to merge 2 commits into from

Conversation

bojanrajh
Copy link
Contributor

This PR fixes the copy/paste functionality for textual codeblocks.

See broken example - this PR fixes it.

@bojanrajh bojanrajh changed the title fix: textual code fix: textual code copy/paste feature Oct 5, 2023
@bojanrajh
Copy link
Contributor Author

@brc-dd Please, take a look at this one.

@brc-dd
Copy link
Member

brc-dd commented Oct 17, 2023

Hi, your example seems to be working fine for me. I'm able to copy paste both the code blocks there fine. Can you update that to show what exactly is breaking?

@bojanrajh
Copy link
Contributor Author

I swear that was broken last week and I was able to fix the issue locally. See production example (source), example 2, example 3, example 4 - all using txt or text language and not being transformed to span elements.

image

I'll try to find a better reproduction, maybe there's an issue with shiki.

@brc-dd
Copy link
Member

brc-dd commented Oct 17, 2023

Something seems wrong with the blocks on your prod site. For some reason the adaptive theme blocks are being generated there when clearly you have single theme for code blocks. Is the config of your docs public?

@bojanrajh bojanrajh closed this Oct 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants