Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nav): display nav if locales are present #321

Merged
merged 1 commit into from
Jun 23, 2021
Merged

fix(nav): display nav if locales are present #321

merged 1 commit into from
Jun 23, 2021

Conversation

m4dz
Copy link
Contributor

@m4dz m4dz commented Jun 21, 2021

This PR fix how the NavBar is shown. Right now, a themeConfig.repo key is mandatory to display the NavBar, regardless nav or locales config are defined.

@m4dz
Copy link
Contributor Author

m4dz commented Jun 21, 2021

Also, may be related to #322

@posva posva changed the title Fix nav show property fix(nav): display nav if locales are present Jun 21, 2021
@m4dz m4dz requested a review from posva June 22, 2021 10:22
posva
posva approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit e76e6ec into vuejs:master Jun 23, 2021
YunYouJun pushed a commit to YunYouJun/vitepress that referenced this pull request Aug 30, 2021
@m4dz @YunYouJun
fix(nav): display nav if locales are present (vuejs#321)
1f1eb21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m4dz @posva