Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edit-link): let frontmatter overwrite global editLink #340

Merged
merged 2 commits into from
Jul 22, 2021
Merged

fix(edit-link): let frontmatter overwrite global editLink #340

merged 2 commits into from
Jul 22, 2021

Conversation

dirkdev98
Copy link
Contributor

Allows overwriting the editLinks setting via the frontmatter editLink property.

Closes #334

posva
posva approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva changed the title fix(edit-link): let page frontmatter overwrite global editLink setting fix(edit-link): let frontmatter overwrite global editLink Jul 22, 2021
@posva posva merged commit cfbba80 into vuejs:master Jul 22, 2021
@dirkdev98 dirkdev98 deleted the fix/edit-link branch July 23, 2021 06:04
YunYouJun pushed a commit to YunYouJun/vitepress that referenced this pull request Aug 30, 2021
@dirkdev98 @posva @YunYouJun
fix(edit-link): let frontmatter overwrite global editLink (vuejs#340)
884c99d 
Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@posva posva posva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit link can't be disabled via frontmatter
2 participants
@dirkdev98 @posva