Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using components in navigation bar #4000

Merged
merged 14 commits into from
Jul 7, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Jun 29, 2024

✔️ I need to add an example/test...

closes #3998

@userquin userquin marked this pull request as ready for review June 29, 2024 12:21
@userquin userquin requested a review from brc-dd June 29, 2024 12:21
@userquin userquin changed the title feat: allow using components in menu items feat: allow using components in navigation bar Jun 29, 2024
@userquin
Copy link
Member Author

userquin commented Jul 5, 2024

We should also add fly, maybe including mode type: type Mode = 'screen' | 'fly' | undefined or type Mode = 'screen' | 'fly' | 'navbar'

@userquin
Copy link
Member Author

userquin commented Jul 5, 2024

@brc-dd same component in multiples places, no makes sense, do we need the new mode prop? maybe not, since we should always have screen in screen menu (we'll need to add screen prop when custom component in root, check last screenshot)

fly-screen-navbar

fly-screen-navbar-2

@brc-dd
Copy link
Member

brc-dd commented Jul 7, 2024

Do we need some option to move component to flyout in medium viewports? Inside this thing:

image

(it might make things more complicated though, we can probably support that later?)

@userquin
Copy link
Member Author

userquin commented Jul 7, 2024

I guess there is no need, fly will be used when the custom component is not a root child in the navbar entry. If the custom component is in the root navbar, VP will not use fly (will use media query bp to collapse or expand the full navbar)

TODO: adjust docs, restore some component inside nested items
@brc-dd brc-dd force-pushed the userquin/feat-allow-use-components-in-nav-item branch from 382f482 to f3d7be7 Compare July 7, 2024 11:01
@brc-dd brc-dd merged commit fa87d81 into main Jul 7, 2024
7 checks passed
@brc-dd brc-dd deleted the userquin/feat-allow-use-components-in-nav-item branch July 7, 2024 16:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow use components inside navbar
2 participants