-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config, theme): add clientOnly marker #4663
base: main
Are you sure you want to change the base?
feat(config, theme): add clientOnly marker #4663
Conversation
@brc-dd Seems like the data loading test on windows-latest could randomly timeout due to fluctuations of GitHub server. There is literally nothing changed in the previous failed test. ![]() |
@zhangyx1998 You need to first resolve some of the conflicts in your code. Just try to cross check. |
Thanks for reminding! I'll find time to resolve it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conflicts resolved!
Test/node20 failed because it lacks support for Iterator helpers. The newly introduced package relies on |
Description
clientOnly(object: any)
andisClientOnly(object: any): boolean
APIs to mark an object as client-only.ClientOnly.ts
to accept an optional propisClientOnly: Boolean
so its behavior can be programmatically controlled.Linked Issues
closes #3367
Additional Context
Before (22 occurrences of a sidebar item)
After (4 irrelevant occurrences)
Tip
The author of this PR can publish a preview release by commenting
/publish
below.