Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar): use base when creating link #74

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 27, 2020

create a link based on the absolute url, this might cause problems if the children start with '/'

@kiaking
Copy link
Member

kiaking commented Sep 3, 2020

Yeah, I think we should handle links starting with /, because I think it's easier for users to add config like,

{ text: 'Guide', link: '/guide/' }

Although, I think we could just enforce users to not add trailing slash on base url 😳

@kiaking kiaking merged commit 79bc9fb into vuejs:master Sep 3, 2020
@pikax pikax deleted the feat/sidebar_base_link branch September 3, 2020 07:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants