Skip to content

fix: fix memory leak of detached DOM tree #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2017
Merged

fix: fix memory leak of detached DOM tree #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { noop, warn } from './util'

export function collectDataFromConstructor (vm: Vue, Component: VueClass<Vue>) {
// override _init to prevent to init as Vue instance
const originalInit = Component.prototype._init
Component.prototype._init = function (this: Vue) {
// proxy to actual vm
const keys = Object.getOwnPropertyNames(vm)
Expand All @@ -29,6 +30,9 @@ export function collectDataFromConstructor (vm: Vue, Component: VueClass<Vue>) {
// should be acquired class property values
const data = new Component()

// restore original _init to avoid memory leak (#209)
Component.prototype._init = originalInit

// create plain data object
const plainData = {}
Object.keys(data).forEach(key => {
Expand Down