bugfix: collect decorated class properties #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktsn
suggested changes
Jun 20, 2018
Member
ktsn
left a comment
ktsn
left a comment
There was a problem hiding this comment.
Looks like the diff does not respect existing code format. Can you tidy it up?
- Need a space after
ifkeyword. - Use space instead of tab for indentation.
test/test-babel.js
Outdated
| @decorator2('field2') | ||
| field2 | ||
|
|
||
| foo |
Member
There was a problem hiding this comment.
Can we remove this prop to only focus what we want to test in this block?
test/test.ts
Outdated
|
|
||
| it('data: should collect from decorated class properties', () => { | ||
|
|
||
| const decorator1 = (value: any) => (_: any, __:any ): any => { |
Member
There was a problem hiding this comment.
Please use more descriptive name like valueDecorator, getterDecorator.
test/test.ts
Outdated
| } | ||
| } | ||
|
|
||
| const decorator2 = (value: any) => (_: any, __:any ): any => { |
Member
There was a problem hiding this comment.
(_: any, __:any ): any
Please fix the position of space. (add a space after second colon and remove the space before closing brace)
Looks like there is a kind of things in other place.
Contributor
Author
|
@ktsn fixed 👌 |
ktsn
approved these changes
Oct 9, 2018
Member
|
Thank you for your contribution 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should collect class properties which decorated by 3rd typescript written decorators library.
Check the added unit tests for details :)