Add filename when in handlebars errors (#407)

@posva nice!
vuejs · Mar 20, 2017 · 439aece · 439aece
1 parent c8801b6
commit 439aece
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 1 deletion.
diff --git a/lib/generate.js b/lib/generate.js
@@ -115,7 +115,10 @@ function renderTemplateFiles (skipInterpolation) {
         return next()
       }
       render(str, metalsmithMetadata, function (err, res) {
-        if (err) return next(err)
+        if (err) {
+          err.message = `[${file}] ${err.message}`
+          return next(err)
+        }
         files[file].contents = new Buffer(res)
         next()
       })

diff --git a/test/e2e/mock-error/meta.js b/test/e2e/mock-error/meta.js
@@ -0,0 +1,9 @@
+module.exports = {
+  prompts: {
+    name: {
+      type: 'string',
+      required: true,
+      message: 'Name'
+    }
+  }
+}
diff --git a/test/e2e/mock-error/template/readme.md b/test/e2e/mock-error/template/readme.md
@@ -0,0 +1 @@
+{{error,name}}
diff --git a/test/e2e/test.js b/test/e2e/test.js
@@ -17,6 +17,7 @@ const MOCK_TEMPLATE_REPO_PATH = path.resolve('./test/e2e/mock-template-repo')
 const MOCK_TEMPLATE_BUILD_PATH = path.resolve('./test/e2e/mock-template-build')
 const MOCK_METADATA_REPO_JS_PATH = path.resolve('./test/e2e/mock-metadata-repo-js')
 const MOCK_SKIP_GLOB = path.resolve('./test/e2e/mock-skip-glob')
+const MOCK_ERROR = path.resolve('./test/e2e/mock-error')
 
 function monkeyPatchInquirer (answers) {
   // monkey patch inquirer
@@ -223,4 +224,12 @@ describe('vue-cli', () => {
     expect(getTemplatePath('..')).to.equal(path.join(__dirname, '/../../..'))
     expect(getTemplatePath('../template')).to.equal(path.join(__dirname, '/../../../template'))
   })
+
+  it.only('points out the file in the error', done => {
+    monkeyPatchInquirer(answers)
+    generate('test', MOCK_ERROR, MOCK_TEMPLATE_BUILD_PATH, err => {
+      expect(err.message).to.match(/^\[readme\.md\] Parse error/)
+      done()
+    })
+  })
 })