--no-fix option is ignored by vue-cli-service when using typescript.

[BenoitAverty]

Version

3.0.0-beta.6

Reproduction link

https://github.com/BenoitAverty/vue-cli-test-tslint

Steps to reproduce

Run npm run lint -- --no-fix or npx run vue-cli-service lint --no-fix.

What is expected?

The lint errors should be reported but no file should be changed.

What is actually happening?

Errors are fixed in the file and not reported.

---

I would like to run linting in a precommit hook but not format the files. Currently this is not possible.

[dhensche]

After some digging, appears to be related to https://github.com/substack/minimist/issues/54 and

vue-cli/packages/@vue/cli-plugin-typescript/lib/tslint.js

Line 11 in e65110f

fix: !args['no-fix'],

[BenoitAverty]

Nice catch. It's probably a unix convention. For example, in git, the --no-XXX options are used to override a previous --XXX. minimist seems to have this convention.

[dhensche]

Yeah, I'm working on a fix right now. Not a ton of experience writing tests so that is taking most of my time 😨

[BenoitAverty]

Awesome thanks. Don't hesitate to ask if you run into any difficulties (I'll help as best as I can but I'm not very familiar with vue cli 3 yet)

[BenoitAverty]

in the meantime, I think npm run lint -- --no-fix=true should work as an ugly workaround.

@dhensche If you open a PR, I think the same bug is present in the eslint plugin (when typescript is not chosen)

[dhensche]

@BenoitAverty The if block inverting the argument doesn't do anything, but because of the minimist conventions the --no-fix argument comes into the args property as fix: false and results in the argument working as expected.

vue-cli/packages/@vue/cli-plugin-eslint/lint.js

Line 10 in e65110f

if (args['no-fix']) {

Could probably just get rid of that whole if block

[yyx990803]

fixed via #1115