-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart Sass support as a stylesheet preprocessor option #1782
Comments
We don't have a hard dependency on node-sass - sass-loadee needs it. Does sass-loadee support dart-sass as well, or does a fork exist or something? At the end of the day we need a loader for it. |
As I can see, in webpack-contrib/sass-loader#435, it's not currently supported inside sass-loader. The merge request webpack-contrib/sass-loader#573 let I think it's a good idea to have
But I think you'll wait |
Well I'm not sure how using dart sass would work without a loader supporting it, since the whole build process of vue-cli is built around webpack. |
@LinusBorg webpack-contrib/sass-loader#573 is the loader it could be implemented as a generator time option... like fountainjs has been doing it... |
Well, that PR hasn't been merged yet, so as of today there's no loader that supports dart -sass, right? |
The prophecy is upon us:
commit: bed9fb5799a90020d43f705ea405f85b368621d7 |
IMO dart-sass should be the default sass compiler because now it's the official sass compiler. |
It's also my opinion but like I see after the merge request of the sass loader, |
I tried to use /* vue.config.js */
module.exports = {
css: {
loaderOptions: {
sass: {
implementation: require('sass')
}
}
}
} "devDependencies": {
"@vue/cli-plugin-babel": "^3.0.4",
"@vue/cli-plugin-typescript": "^3.0.4",
"@vue/cli-service": "^3.0.4",
"sass": "^1.14.1",
"sass-loader": "^7.0.1",
"typescript": "^3.0.0",
"vue-template-compiler": "^2.5.17"
} |
What problem does this feature solve?
node-sass is the most painful node dependency in the entirety of the npm ecosystem. Plus dart sass is faster, allows code sharing with docker (no binaries), never breaks installations after a system or node update...
I realize there will be limitations... which I'm willing to work around for the benefits
What does the proposed API look like?
The text was updated successfully, but these errors were encountered: