Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid modifying git hooks if created as sub directory in an existing git repo #2131

Closed
bseib opened this issue Aug 9, 2018 · 1 comment
Closed

Comments

@bseib
Copy link

bseib commented Aug 9, 2018

Version

3.0.0-rc.9

Node and OS info

Node 8.11.3 / npm 6.3.0 / MacOS (and Win7)

Steps to reproduce

// cd into exiting git project
vue create foo
// choose "manually select features"
// deselect all features (actually it doesn't matter what you select)
image

When the dependencies are installed, Yorkie gets installed, and Git hooks are setup, whether I want them or not.

image

What is expected?

I don't expect my git hooks to be touched unless I require them and have been informed that they will be changed.

If users select a feature that requires git hooks, they should be told that the hooks will be installed (and perhaps how to uninstall them in the future -- maybe name the hooks more obviously). If the features they select do not require git hooks, then no hooks should be installed.

What is actually happening?

After running vue create foo, if you list the contents of .git/hooks, you will find the 19 new hooks have been installed by Yorkie.

When the foo directory is deleted, the hooks still expect foo directory to exist and give errors when git commands are used.


Here's a conversation on the forum on this topic: https://forum.vuejs.org/t/vue-cli-3-yorkie-and-git-stash/39828

@yyx990803 yyx990803 changed the title allow git hooks to be untouched upon vue create Avoid modifying git hooks if created as sub directory in an existing git repo Aug 9, 2018
@yyx990803
Copy link
Member

After reading the forum thread I've edited the title to be more specific.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants