Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue create <project> is unable to detect and install git hooks in parent .git dir #2557

Open
pravinpr opened this issue Sep 19, 2018 · 3 comments

Comments

@pravinpr
Copy link

Version

3.0.1

Reproduction link

https://github.com/pravinpr/vue-create-git-hook-issue

Node and OS info

node 8.11.4 / npm 5.6.0 / MacOS High Sierra 10.13.6

Steps to reproduce

mkdir vue-create-git-hook-issue
cd vue-create-git-hook-issue
git init
mkdir java
echo "some other project" > java/README.md
vue create app

What is expected?

git hooks should have been installed in vue-create-git-hook-issue/.git/hooks/
or vue create should give option to specify where to install the git hooks

What is actually happening?

vue create app output contains below message

setting up Git hooks
can't find .git directory, skipping Git hooks installation

@LinusBorg
Copy link
Member

LinusBorg commented Sep 20, 2018

That was removed on purpose, see #2131

We would be open for ideas how to provide a solution that can work for both needs, though.

@pravinpr
Copy link
Author

pravinpr commented Sep 21, 2018

Can we not provide an option to take the location of git dir in vue create if we want vue create to setup the git hooks?

And probably we can enforce that this option would work only when vue create is running in a subdirectory of git repo.

@pravinpr
Copy link
Author

pravinpr commented Nov 9, 2018

any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants